feat(paywall): add base component, API interface, script#702
Merged
Conversation
Deployment results
Logs #25667347400 |
…om setPrice method
DarianM
reviewed
May 11, 2026
| redirectUrl, | ||
| }) | ||
| }, | ||
| async *getStatus(paymentId, signal) { |
Member
There was a problem hiding this comment.
duplicate of cdn widget.ts .
getStatus is identical in both files. since initiatePayment, fetchQuote, and getWallet are already extracted to a shared module, this should follow the same pattern maybe ?
Member
Author
There was a problem hiding this comment.
Was thinking if we'll need this in same manner as widget. If we need it as same as widget, will extract then. So leaving as is until we actually implement it.
DarianM
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #670
Part of #672
Part of #677